[enhancement] Improve naming of automatically generated tests #3265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vkarak added prio: normal enhancement logging reporting 
teojgo approved these changes Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
nametest attribute is not anymore a full alias ofdisplay_name. It hides all special parameters starting with$that are inserted by the automatic test generation options, such as--repeat,--distributeetc.Also the test name of the parameterized test with
--distributedoes not contain any more the partition name, but instead the partition has become a special test parameter.Finally, all the special parameters are converted to non-loggable.
The motivation behind these changes is that previously both the special parameters and the different name of the "distributed" tests were causing confusion with logging (e.g., different log files, different headers etc.) and were preventing results comparisons with the new
--performance-compareoption.