Skip to content

[bugfix] Handle None cpu model name returned from archspec #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2024
Merged

[bugfix] Handle None cpu model name returned from archspec #3199

merged 1 commit into from
May 17, 2024

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented May 16, 2024

Fixes #3192
@teojgo teojgo requested review from jack-morrison and vkarak May 16, 2024 16:02
@teojgo teojgo self-assigned this May 16, 2024
vkarak
vkarak requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your PR on master and target master instead, so as to release this in the next patch level release?

I thought that we had already bumped archspec in master. Sorry!
@jack-morrison
Copy link
Member

jack-morrison commented May 16, 2024

Thanks for this catch @teojgo!
@teojgo teojgo changed the base branch from develop to master May 17, 2024 06:48
@teojgo teojgo force-pushed the bugfix/none_cpu_model branch from 15610a4 to c568744 Compare May 17, 2024 06:50
Handle None cpu model name from archspec
84f22f2 
Signed-off-by: Theofilos Manitaras <manitaras@cscs.ch>
@teojgo teojgo force-pushed the bugfix/none_cpu_model branch from c568744 to 84f22f2 Compare May 17, 2024 07:11
@teojgo teojgo changed the base branch from master to develop May 17, 2024 07:12
@vkarak vkarak changed the title [bugfix] Handle None cpu model name from archspec [bugfix] Handle None cpu model name returned from archspec May 17, 2024
@vkarak vkarak merged commit da0c692 into reframe-hpc:develop May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autodetection bugfix prio: normal

3 participants

@teojgo @jack-morrison @vkarak