[feat] Add a perflog entry also when sanity fails #3189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-05-15 10:45:12 UTC |
vkarak commented May 13, 2024
vkarak commented May 13, 2024
vkarak force-pushed the feat/always-log-perftests branch from 662c93e to 28aa6c3 Compare 
teojgo requested changes May 15, 2024
teojgo approved these changes May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The idea is the same as exposed in the issue.
In case of sanity failures, we execute also the performance stage but in dry-run mode suppressing any non-aborting exception. To achieve so, we also extended the dry-run mode inside the performance stage to also generate the
perfvalueswhich are required by the logging handlers for emitting the performance record.In case of sanity failures, the performance values will be logged as
None.Todos
check_fail_reasonlog format placeholder for allowing the fail reason to be also logged.Closes #3186.