Implement Hash for f32 and f64 only. #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The previous generic implementation was slow, and potentially incorrect for custom types. Fixes #142.
tisonkun reviewed Feb 19, 2025
Comment on lines +2039 to +2048
| impl<T: PrimitiveFloat> Hash for OrderedFloat<T> { | ||
| fn hash<H: Hasher>(&self, hasher: &mut H) { | ||
| let bits = if self.0.is_nan() { | ||
| T::CANONICAL_NAN_BITS | ||
| } else { | ||
| self.0.canonical_bits() | ||
| }; | ||
| bits.hash(hasher); | ||
| } | ||
| } |
There was a problem hiding this comment.
This breaks the original hash result because it doesn't call raw_double_bits anymore.
Our use case depends on stable hash results. @mbrubeck would you give some background why change the result? (I can understand we implement only for f32/f64)
There was a problem hiding this comment.
Sorry about that. The main reason for that change was performance. (See #142 for details.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The previous generic implementation was slow, and potentially incorrect for custom types. Fixes #142.