Format replies from pipelines just as replies from regular calls #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pietern added a commit that referenced this pull request Dec 5, 2011
Format replies from pipelines just as replies from regular calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This changeset removes
#call_pipelinedfrom thePipelineobject, and uses#call_pipelineinstead. This encapsulates the logic to both copy over the list of commands and the list of post-processing blocks. The patch is a solution to issue #154.Because this changes the return value for commands executed in pipelines, we should definitely wait for 2.3 before merging this. Until that is done, we can iterate a bit and see if this approach is the way to go.
What do you guys think?