Ignore "Interrupted system call" errors in PubSubWorkerThread #738
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The pubsub worker thread was sometimes dying on me silently because my process was interrupted by a signal while
pubsub.get_message -> pubsub.parse_response -> connection.can_read -> select.selectwas blocking.This fix simply ignores
InterruptedErrors raised during theselectpoll and retries. I have been testing this in production for about half a year now.Note that this is only needed for Python < 3.5. In 3.5
selectignores interruptions and retries automatically (https://docs.python.org/3/library/select.html#select.select).