Skip to content

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Jul 18, 2023

supercedes #2480

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -13.12 ⚠️

Comparison is base (2732a85) 90.65% compared to head (698062d) 77.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2853 +/- ## =========================================== - Coverage 90.65% 77.54% -13.12%  =========================================== Files 126 126 Lines 32229 32232 +3 =========================================== - Hits 29217 24993 -4224  - Misses 3012 7239 +4227 
Impacted Files Coverage Δ
tests/test_asyncio/test_cluster.py 18.18% <20.00%> (-79.09%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h changed the title Debug command support in cluster docker Change cluster docker to edge and enable debug command Jul 25, 2023
r.function_list(withcode=True)[node][0][7]
== f"#!{engine} name={lib} \n {function}".encode()
)
code = f"#!{engine} name={lib} \n {function}".encode()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the gears test code not be here? I think this contains part of your discussion with @shacharPash for #2861

@dvora-h dvora-h merged commit 2c2860d into master Jul 26, 2023
@dvora-h dvora-h deleted the ck-debugs2 branch July 26, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

3 participants