Skip to content

Adding support for WITHSCORE in zrank #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Adding support for WITHSCORE in zrank #2698

wants to merge 6 commits into from

Conversation

SoulPancake
Copy link
Contributor

@SoulPancake SoulPancake commented Apr 6, 2023 •
edited by chayim
Loading

closes #2758
closes #2689
@SoulPancake SoulPancake marked this pull request as draft April 6, 2023 03:18
@chayim
Copy link
Contributor

chayim commented Apr 23, 2023

@SoulPancake I updated your code to fix the linter issue. Maybe take a stab at it from here?
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 47.05% and project coverage change: -0.04 ⚠️

Comparison is base (2d9b5ac) 92.30% compared to head (c8ebdeb) 92.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #2698 +/- ## ========================================== - Coverage 92.30% 92.26% -0.04%  ========================================== Files 116 116 Lines 30214 30229 +15 ========================================== + Hits 27888 27891 +3  - Misses 2326 2338 +12
Impacted Files Coverage Δ
tests/test_asyncio/test_commands.py 97.70% <33.33%> (-0.19%) ⬇️
tests/test_commands.py 89.71% <33.33%> (-0.11%) ⬇️
redis/commands/core.py 82.05% <80.00%> (-0.03%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
@SoulPancake SoulPancake marked this pull request as ready for review May 20, 2023 15:56
@SoulPancake
Copy link
Contributor Author

@chayim Can you take a look at this
@SoulPancake SoulPancake mentioned this pull request May 21, 2023
Merged
6 tasks
@chayim chayim added the feature New feature label May 24, 2023
@chayim
Copy link
Contributor

chayim commented May 24, 2023

LGTM @SoulPancake . Thank you for revisiting!
@chayim chayim changed the title Feat: add support for zrank7.2 Adding support for zrank May 24, 2023
@uglide uglide changed the title Adding support for zrank Adding support for WITHSCORE in zrank May 25, 2023
@uglide
Copy link
Contributor

uglide commented May 25, 2023

The PR title was misleading. I've updated it.
@chayim
Copy link
Contributor

chayim commented May 28, 2023

@dvora-h given #2758 being merged, maybe you can double-check this?
@dvora-h
Copy link
Collaborator

dvora-h commented Jun 19, 2023

Closing as this is already merged in #2758.
(Sorry, @SoulPancake I missed it before I merged)
@dvora-h dvora-h closed this Jun 19, 2023
@SoulPancake SoulPancake deleted the zrank7.2 branch June 19, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature ready-for-merge

5 participants

@SoulPancake @chayim @codecov-commenter @uglide @dvora-h