update json().arrindex() default values

[davemcphee]

Pull Request check-list

Please make sure to review and check all of these items:

• Does $ tox pass with this change (including linting)?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?
• Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Refactor default start / stop values in the json().arrindex() function. Previously, if stop was unset, the stop value would default to -1. If the value being searched was the last element in an array, and stop was set to -1, the server would reply with -1 instead of the element's index.

eg.: given a json object myarr: {"l": ["a", "b", "c", "d"]}:

localhost:36379> JSON.ARRINDEX myarr $.l '"d"' # no start or stop set 1) (integer) 3 localhost:36379> JSON.ARRINDEX myarr $.l '"d"' 0 10000 # stop set to some huge value 1) (integer) 3 localhost:36379> JSON.ARRINDEX myarr $.l '"d"' 0 -1 # stop set to -1 1) (integer) -1 localhost:36379> JSON.ARRINDEX myarr $.l '"d"' 0 # start set to 0, but stop omitted 1) (integer) 3 

By only appending start and stop values to the JSON.ARRINDEX command if they're set, the python client more closely mimics redis' behaviour.

Fixes #2481

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (6c708c2) 92.31% compared to head (69ea3da) 92.25%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@ Coverage Diff @@ ## master #2611 +/- ## ========================================== - Coverage 92.31% 92.25% -0.07%  ========================================== Files 115 115 Lines 29744 29760 +16 ========================================== - Hits 27459 27455 -4  - Misses 2285 2305 +20 

Impacted Files	Coverage Δ
redis/commands/json/commands.py	89.51% <100.00%> (+0.44%)	⬆️
tests/test_asyncio/test_json.py	100.00% <100.00%> (ø)
tests/test_json.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dvora-h]

Thanks for the fix!

[davemcphee]

Fixed the bool checks - forgot that 0 is falsey. Added a few more unit tests.

[dvora-h]

@davemcphee Great, thank you! Can you add the tests also to the async test (in test_asyncio/test_json.py)?