Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jun 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2218
closes #2223

@dvora-h dvora-h requested a review from chayim June 27, 2022 11:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #2254 (6a2991c) into master (bedf3c8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #2254 +/- ## ========================================== + Coverage 91.83% 91.85% +0.02%  ========================================== Files 108 108 Lines 27690 27782 +92 ========================================== + Hits 25429 25520 +91  - Misses 2261 2262 +1 
Impacted Files Coverage Δ
redis/lock.py 100.00% <ø> (ø)
redis/commands/cluster.py 93.64% <0.00%> (-0.57%) ⬇️
tests/test_asyncio/test_cluster.py 97.44% <0.00%> (-0.20%) ⬇️
redis/asyncio/client.py 92.73% <0.00%> (-0.13%) ⬇️
redis/commands/core.py 82.11% <0.00%> (ø)
tests/test_timeseries.py 100.00% <0.00%> (ø)
tests/test_asyncio/test_retry.py 100.00% <0.00%> (ø)
redis/client.py 88.68% <0.00%> (+0.02%) ⬆️
redis/asyncio/cluster.py 89.96% <0.00%> (+0.05%) ⬆️
tests/conftest.py 86.50% <0.00%> (+0.05%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedf3c8...6a2991c. Read the comment docs.

@dvora-h dvora-h changed the title Fix backwards compatibility from 4.3.2 in Lock.acquire() Fix backward compatibility from 4.3.2 in Lock.acquire() Jun 27, 2022
@chayim chayim added bug Bug breakingchange API or Breaking Change labels Jun 27, 2022
@dvora-h dvora-h merged commit e9c2852 into redis:master Jun 27, 2022
@dvora-h dvora-h deleted the lock branch June 18, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange API or Breaking Change bug Bug

3 participants