Skip to content

Conversation

@dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Apr 27, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1948

@dvora-h dvora-h added feature New feature redis-7 labels Apr 27, 2022
@dvora-h dvora-h requested a review from chayim April 27, 2022 12:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #2149 (a830157) into master (fa7b3f6) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

@@ Coverage Diff @@ ## master #2149 +/- ## ========================================== - Coverage 92.27% 92.22% -0.06%  ========================================== Files 105 105 Lines 25246 25266 +20 ========================================== + Hits 23297 23302 +5  - Misses 1949 1964 +15 
Impacted Files Coverage Δ
redis/commands/core.py 83.28% <9.09%> (-0.47%) ⬇️
tests/test_commands.py 91.83% <33.33%> (-0.17%) ⬇️
redis/asyncio/connection.py 84.72% <0.00%> (-0.12%) ⬇️
tests/test_asyncio/test_search.py 98.68% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7b3f6...a830157. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvora-h let me know what you think about the style change. I think it reads cleaner.

@dvora-h
Copy link
Collaborator Author

dvora-h commented May 3, 2022

It's realy better, I changed it.

@dvora-h dvora-h merged commit 3a88022 into redis:master May 8, 2022
@dvora-h dvora-h deleted the command-list branch May 9, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants