Support multiple parametrs on CONFIG SET #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Avital-Fine commented Mar 16, 2022
Codecov Report
@@ Coverage Diff @@ ## master #2042 +/- ## ======================================= Coverage 94.83% 94.83% ======================================= Files 360 360 Lines 3366 3366 Branches 411 411 ======================================= Hits 3192 3192 Misses 89 89 Partials 85 85 Continue to review full report at Codecov.
|
0ex-d reviewed Mar 16, 2022
| const args = ['CONFIG', 'SET', parameter, value]; | ||
| | ||
| if (mulitipleParams) { | ||
| mulitipleParams.forEach(pair => args.push(pair[0], pair[1])); |
There was a problem hiding this comment.
should we destructure for clarity?
Suggested change
| mulitipleParams.forEach(pair => args.push(pair[0], pair[1])); | |
| mulitipleParams.forEach(([parameter, value]) => args.push(parameter, value)); |
leibale approved these changes Mar 20, 2022
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
* support multiple parametrs on CONFIG SET * clean code Co-authored-by: leibale <leibale1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
CONFIG SET
Closes #1936
Checklist
npm testpass with this change (including linting)?