Skip to content

Support CLUSTER commands #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 28, 2022
Merged

Support CLUSTER commands #2015

merged 14 commits into from
Mar 28, 2022

Conversation

@Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine commented Feb 28, 2022 •
edited
Loading

Description

Support CLUSTER [...] commands

closes #1933, closes #1932, closes #1931, closes #1933, closes #1930, closes #1929, closes #1928, closes #1926, closes #1925, closes #1924, closes #1922, closes #1921, closes #1920, closes #1922, closes #1919

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #2015 (a82770f) into master (515adf1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head a82770f differs from pull request most recent head 4350c57. Consider uploading reports for the commit 4350c57 to get more accurate results

@@ Coverage Diff @@ ## master #2015 +/- ## ========================================== + Coverage 94.58% 94.65% +0.07%  ========================================== Files 372 384 +12 Lines 3451 3499 +48 Branches 420 421 +1 ========================================== + Hits 3264 3312 +48  Misses 101 101 Partials 86 86
Impacted Files Coverage Δ
packages/client/lib/commands/CLUSTER_FLUSHSLOTS.ts 100.00% <ø> (ø)
...kages/client/lib/commands/CLUSTER_GETKEYSINSLOT.ts 100.00% <ø> (ø)
packages/client/lib/commands/CLUSTER_MEET.ts 100.00% <ø> (ø)
packages/client/lib/commands/CLUSTER_SLOTS.ts 100.00% <ø> (ø)
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLUSTER_ADDSLOTS.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLUSTER_BUMPEPOCH.ts 100.00% <100.00%> (ø)
...ient/lib/commands/CLUSTER_COUNT-FAILURE-REPORTS.ts 100.00% <100.00%> (ø)
...ges/client/lib/commands/CLUSTER_COUNTKEYSINSLOT.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLUSTER_DELSLOTS.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515adf1...4350c57. Read the comment docs.
@Avital-Fine Avital-Fine requested a review from leibale March 1, 2022 07:05
leibale
leibale reviewed Mar 6, 2022
View reviewed changes
leibale
leibale reviewed Mar 6, 2022
View reviewed changes
@Avital-Fine Avital-Fine requested a review from leibale March 15, 2022 07:11
@leibale leibale merged commit 5821fcb into master Mar 28, 2022
@leibale leibale deleted the CLUSTER-Commands branch March 28, 2022 22:31
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
@Avital-Fine @leibale
Support CLUSTER commands (redis#2015)
4123e7a 
* Support CLUSTER commands * add some client tests * remove only * delete cluster slaves * delete reset clietn test * SET SLOT * test with client * fix fail * Update CLUSTER_COUNTKEYSINSLOT.spec.ts * move commands to client/commands.ts * clusterNode * remove CLUSTER-SET-CONFIG-EPOCH test with client * clean code Co-authored-by: leibale <leibale1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@Avital-Fine @codecov-commenter @leibale