added examples for all redis commands #1377
Conversation
| Woah! That's a huge PR. Thanks! A few things we need though - right now all the example lack any kind of error handling nor connection configuration which should be included as a minimum (both are a huge source of questions). Aside from that, the approach is great. |
| Thanks for your nice answer. Yeah, I know this a huge PR but I think this is necessary for this repository especially for the new developers who will use this repo in their projects. |
| By the way, before opening PR I run npm test command on your repo and I get four error and these errors were related to the connections it means these errors are not related to my code and if you wish you can check it |
| using this in some capacity would be a solid improvement to the docs. I imagine a lot of developers find themselves keyword searching for a package that implements a specific redis query. i.e., the only reason I found myself here is I was looking for the implementation of setrange please don't let this die! |
| // psetex: Set the value and expiration in milliseconds of a key | ||
| | ||
| client.psetex('mykey', 1000, 'Hello', function (err, res) { | ||
| console.log(res); // OK | ||
| }); |
There was a problem hiding this comment.
setex is not for milliseconds but seconds
4 participants
Pull Request check-list
Please make sure to review and check all of these items:
npm testpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.