Skip to content

Fix race condition in clusterNodes.Addrs() #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
+4 −2
Merged

Fix race condition in clusterNodes.Addrs() #3219

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b56aa1
Fix race condition in clusterNodes.Addrs()
shawnwgit Jan 5, 2025
89bcad3
Merge branch 'master' into s_fix_race
ndyakov Jan 30, 2025
3ada37e
Merge branch 'master' into s_fix_race
ndyakov Feb 1, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions osscluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,11 @@ func (c *clusterNodes) Addrs() ([]string, error) {
closed := c.closed //nolint:ifshort
if !closed {
if len(c.activeAddrs) > 0 {
addrs = c.activeAddrs
addrs = make([]string, len(c.activeAddrs))
copy(addrs, c.activeAddrs)
} else {
addrs = c.addrs
addrs = make([]string, len(c.addrs))
copy(addrs, c.addrs)
}
}
c.mu.RUnlock()
Expand Down
Loading