Dont quit scan unmarshal on first failure #2255
Open
+26 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| the go 1.18 build seems to have failed for reasons unrelated to this PR. Im not sure how to rerun the flaky test |
| @ofekshenawa this one makes sense to me, but in the rest of the library we often fail on the first error that occurs. Let me know what you think. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Periodically a data type might need to change in a redis struct. I've personally had this occur if something was a string and i'd now like it to be a more specific type (maybe a boolean). The current scan method exits on the first field unmarshal failure. This PR allows scan to continue until the end and returns all field errors concatenated together.
This allows the caller to check for their specific "migrated" field in the error and ignore it if they're ok with that going back to it's zero value