Backport wrapMultiExec() cmds copy bug fix from v8 #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wspowell changed the title 
| This is probably the same bug that was being hit in issue #1386. |
Signed-off-by: monkey92t <golang@88.com>
Signed-off-by: monkey92t <golang@88.com>
Signed-off-by: monkey92t <golang@88.com>
| We did not plan to fix v7 before, it will be very difficult, and we have removed @vmihailenco What do you think? |
Signed-off-by: monkey92t <golang@88.com>
| Since out time is limited, we don't support old versions. But we do accept backports from users if tests are passing. So I think we should merge the first commit, run tests locally (since travis is not working), release a new v7 version, and forget about it (i.e. don't try to fix build / backport other changes). Does that sound good? |
| Yes, I think this is a good idea, I have removed the extra. |
| I performed the test locally and found no problems, I will merge it and release a new version |
| Thanks 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.