Inject OSP CA certificate onto OCP hosts #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tomassedovic requested changes Apr 4, 2017
Contributor
tomassedovic left a comment
tomassedovic left a comment There was a problem hiding this comment.
Looks good, there's a couple of things I'd like to change but I've tested it and it works swell.
fragments/ca_cert.sh Outdated
| | ||
| if [ -n "$CA_CERT" ] ; then | ||
| update-ca-trust enable | ||
| cat >/etc/pki/ca-trust/source/anchors/ca.crt <<EOF |
Contributor
There was a problem hiding this comment.
Can we use cloud-init and the included_files resource to put the file in place?
openshift.yaml Outdated
| description: Extra parameters for openshift-ansible as a JSON string | ||
| default: "" | ||
| | ||
| osp_ca_cert: |
Contributor
There was a problem hiding this comment.
This can be used for more than just the openstack ssl cert -- for example the ldap certificate. Can we rename it to ca_cert or possibly even ca_certs? It works fine if you put more than one certificate in.
| | ||
| osp_ca_cert: | ||
| type: string | ||
| description: Certificate Authority Certificate to be added to trust chain |
Contributor
There was a problem hiding this comment.
Can we mention that this supports multiple certificates?
Added both DNS and cacert variables
tomassedovic approved these changes Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Orignally from @wrichter -
This allows you to enter a trusted ca cert to the openshift nodes and bastion host. This solves the issue https://bugzilla.redhat.com/show_bug.cgi?id=1419182 for me.
To use it, simply add a another parameter to your environment file as such:
trusted_ca_cert: |
-----BEGIN CERTIFICATE-----
<... CERT CONTENT ...>
-----END CERTIFICATE-----