Fix Travis CI build #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This might fix the Travis CI build since v4 still had npm 2 (rackt-cli needs the nested node_modules structure to work atm).
joepvl referenced this pull request Mar 7, 2016
| This was fixed in #100 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changing the Node version to
4in.travis.ymland referring to themasterbranch on GitHub for therackt-clipackage inpackage.jsonfixes the build. This is because:rackt-clineeds npm v2.x to work, and Node 4 ships with that version (but isn't ancient like 0.10, which was used before @timdorr tried to get this package up to date), andrackt-clithat fixed a different (much smaller) issue by updating a dependency, but this hasn't been pushed to npm yetObviously this won't actually fix the tests breaking locally if you're using Node 5.x, but at least we'll be able to look at a green badge again :). If this gets merged, other PRs will need to be rebased onto
master, after which we'll once again be able to easily see which PRs are genuinely breaking tests and which are ready for review.It seems @mzabriskie is super busy with other stuff atm so hopefully someone else from the reactjs org can help us out here. @timdorr perhaps?