Skip to content

require 'react-dom' but still use window.ReactDOM with globals #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

require 'react-dom' but still use window.ReactDOM with globals #141

wants to merge 1 commit into from

Conversation

@ryankshaw
Copy link
Contributor

@ryankshaw ryankshaw commented Oct 14, 2016

when you export the UMD wrapper, you want to commonJS and AMD to require 'react' and 'react-dom' not 'React' and 'ReactDOM'. but you do want to use those capitalized variable names if you are using globals
@ryankshaw
require 'react-dom' but still use window.ReactDOM with globals
c43d048 
when you export the UMD wrapper, you want to commonJS and AMD to require 'react' and 'react-dom' not 'React' and 'ReactDOM'. but you do want to use those capitalized variable names if you are using globals
@ryankshaw ryankshaw closed this Oct 18, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant

@ryankshaw