Skip to content

Allow other components inside TabList #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 14, 2016
Merged

Allow other components inside TabList #123

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
800e3a9
Allow other child types inside TabList
patrick91 Jul 29, 2016
af03fd9
Updated tests
patrick91 Jul 29, 2016
70c5b35
Fix lint issue
patrick91 Jul 29, 2016
d76292a
Don't clone non Tabs elements
patrick91 Jul 29, 2016
f559020
Test that non tab elements are not cloned
patrick91 Aug 10, 2016
4c6dbd6
Don't compare element type by display name
patrick91 Sep 14, 2016
b1e4545
Disable multiple components lint inside Tabs tests
patrick91 Sep 14, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test that non tab elements are not cloned
  • Loading branch information
@patrick91
patrick91 committed Aug 10, 2016
commit f55902034b5e43c94a370f4ed34edb639a448dcf
21 changes: 21 additions & 0 deletions src/components/__tests__/Tabs-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,27 @@ describe('react-tabs', () => {
expect(wrapper.childAt(2).text()).toBe('Hello Bar');
expect(wrapper.childAt(3).text()).toBe('Hello Baz');
});

it('should not clone non tabs element', () => {
Copy link
Collaborator

@danez danez Sep 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to figure out how to test this 👍
You can just add /* eslint-disable react/no-multi-comp */ at the top of the test to disable the lint.
class Demo extends React.Component {
render() {
const plus = <div ref="yolo">+</div>;

return (<Tabs>
<TabList>
<Tab>Foo</Tab>
{plus}
</TabList>

<TabPanel>Hello Baz</TabPanel>
</Tabs>);
}
}

const wrapper = mount(<Demo />);

expect(wrapper.ref('yolo').text()).toBe('+');
});
});

describe('validation', () => {
Expand Down