Fixes #3 #4
Merged
Fixes #3 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| class-test2 seems broken to me, see https://github.com/reactjs/react-codemod/blob/master/test/__tests__/transform-tests.js#L57 which should not add the super class. Seems like something is wrong in class.js that I probably broke at some point. You mind removing those changes? I can look into them soon-ish. |
| While we don't completely require that you extend React.Component yet, we're going to. So I think that's right. |
| Right, so in that case we should remove the option to not extend |
| Ah gotcha, didn't realize it was an option, just thought we changed code without updating the test. I'll remove those changes. |
We set that as the default option for printing but didn't update the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.