Make sure less-than and great-than characters are properly encoded. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
\x3C\x3E is how our CJSX compiler ends up outputting to ES5. I'm not sure if I should add support for other ways of writing these characters as well.
| Not sure about the failure, can't reproduce locally. |
transforms/create-element-to-jsx.js Outdated
There was a problem hiding this comment.
Can you turn this into to individual regexes? Seems way simpler:
value.replace(/</g, '<').replace(/>/g, '>'); 
RSO force-pushed the fix-lt-gt-entities branch from d2c3a27 to 74a9f4b Compare 
| thanks! Would you mind rebasing now that I merged your other changes? :) |
added 2 commits January 12, 2016 09:24
Previously the transform would translate ``` React.createElement("div", null, "\x3C"); ``` To ``` <div><</div>; ``` This PR fixes this by translating `<>` to `<>`. RSO force-pushed the fix-lt-gt-entities branch from 74a9f4b to 1cb1027 Compare cpojer added a commit that referenced this pull request Jan 12, 2016
Make sure less-than and great-than characters are properly encoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously the transform would translate
To
This PR fixes this by translating
<>to<>.