Do not consider history.replaceState() deprecated #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nguyenthidiemmi1995 approved these changes Jun 15, 2019
threepointone approved these changes Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a fix for #123. Potentially this could be made more generic by checking
path.parentPath.value.typeand check if it's CallExpression or something else, but in order to avoid potential false positives I decided to just make the fix for this specific case.Comments welcome! This issue was preventing us from converting some of our classes, and I would be happy if this issue could be resolved and potentially help others.