Support React.__spread/Object.assign in JSX transform #19
Conversation
| I should probably rebase one of these PRs once the other is landed. |
| yeah, I'm sorry, you need to rebase again :) Thanks for the contribution, may I ask where you are using this? :) |
While reviewing the output of the JSX transform I noticed that `React.__spread` attributes not only weren't ignored, they caused all attributes to be lost. I figured that it would probably be better if the transform errors when it doesn't recognize input.
RSO force-pushed the create-element-to-jsx/support-react-spread branch from 6390a9e to 9140737 Compare | Not a problem! I've been actively investigating transforming our (@Hacker0x01) codebase from CoffeeScript (CJSX) to ES2015 by using transforms to turn the ES5 output into ES2015. Currently most of my work lives in https://github.com/Hacker0x01/espresso, but I have plans of removing all the CLI helper stuff and making it a repository filled with transforms (and tests), just like this repository. I want to do this because I plan on running all transforms one by one to make sure there aren't any unforeseen cases that may break (as the assumptions on which some transforms are based are pretty loose). I'm demoing the outcome of my investigations to my team next week, so I'll know after that if/when we decide to go forward with this :-). Thank you for your amazing JSConf talk, it was the spark that ignited this whole project! |
…pread Support React.__spread/Object.assign in JSX transform
| oh man, this is really awesome. We talked about building a CS to JS converter, also using jscodeshift, mainly just out of hate ;) Keep up the good work! |
| @RSO: This looks great! Also let us know if you have any suggestions for jscodeshift. |
4 participants
While reviewing the output of the transform I noticed that the transform lost all attributes for elements that use the
React.__spreadhelper. I decided to fix this and make the transform throw an error when it doesn't recognise a certain attribute. This way we can be more sure that things don't fall through.