Allow for a callExpression as child that's not an element. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can you rebase this? It conflicts with your other pull request that I just merged :) |
| Sure thing! |
The previous code assumed that all children that were of type CallExpression were in fact calls on MemberExpressions. This fix makes sure we also support other calls.
RSO force-pushed the create-element-to-jsx/call-as-children branch from b6f45bf to c2af795 Compare cpojer added a commit that referenced this pull request Dec 10, 2015
Allow for a callExpression as child that's not an element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The previous code assumed that all children that were of type
CallExpression were in fact calls on MemberExpressions. This fix makes
sure we also support other calls.