Add handling for nested destructuring #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mute commented Apr 21, 2017
| | ||
| // Add back any nested destructured children. | ||
| if (nestedPropTypesChildren) { | ||
| // TODO: This shouldn't just use a template string but the `ast-types` docs were too opaque for me to follow. |
Author
There was a problem hiding this comment.
This is the spot that could use some updating from someone with jscodeshift experience.
Contributor
There was a problem hiding this comment.
Those docs are a bit rough, huh.
bvaughn approved these changes Apr 21, 2017
Contributor
bvaughn left a comment
bvaughn left a comment There was a problem hiding this comment.
Thanks for contributing!
This looks fine to me. The TODO can be addressed at some point in the future maybe. Doesn't feel super pressing.
| | ||
| // Add back any nested destructured children. | ||
| if (nestedPropTypesChildren) { | ||
| // TODO: This shouldn't just use a template string but the `ast-types` docs were too opaque for me to follow. |
Contributor
There was a problem hiding this comment.
Those docs are a bit rough, huh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #134 but not in a totally ideal way.