Added more edge-case handling to PropTypes codemod #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bvaughn force-pushed the remove-invalid-PropTypes-equals-PropTypes-assignment branch from fe09fbf to 32faeb4 Compare Previously the codemod might transform: const PropTypes = React.PropTypes; To: const PropTypes = PropTypes; I've now added handling for this (and tests)
bvaughn force-pushed the remove-invalid-PropTypes-equals-PropTypes-assignment branch from 32faeb4 to 1e05d28 Compare bvaughn deleted the remove-invalid-PropTypes-equals-PropTypes-assignment branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously the codemod might transform:
To:
I've now added handling for this (and tests)