Handle mixed imports and requires #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
facebook-github-bot pushed a commit to facebookarchive/WebDriverAgent that referenced this pull request Apr 14, 2017
…ssed Summary: This evening I fixed a few issues with the `React.PropTypes` to `prop-types` codemod: * [[ reactjs/react-codemod#109 | 109 ]]: Remove React import if it was only used for `PropTypes` * [[ reactjs/react-codemod#121 | 121 ]]: Insert `import` or `require` statement in the correct alpha-sorted location * [[ reactjs/react-codemod#127 | 127 ]]: Handle named function parameters * [[ reactjs/react-codemod#128 | 128 ]]: Handle a mix of `import` and `require` statements Reviewed By: flarnie Differential Revision: D4890226 fbshipit-source-id: 36b87bd4395c8cfbe260d2c73f919e62b11439a7
fr0l pushed a commit to badoo/DeviceAgent.iOS.Inspector that referenced this pull request Apr 20, 2020
…ssed Summary: This evening I fixed a few issues with the `React.PropTypes` to `prop-types` codemod: * [[ reactjs/react-codemod#109 | 109 ]]: Remove React import if it was only used for `PropTypes` * [[ reactjs/react-codemod#121 | 121 ]]: Insert `import` or `require` statement in the correct alpha-sorted location * [[ reactjs/react-codemod#127 | 127 ]]: Handle named function parameters * [[ reactjs/react-codemod#128 | 128 ]]: Handle a mix of `import` and `require` statements Reviewed By: flarnie Differential Revision: D4890226 fbshipit-source-id: 36b87bd4395c8cfbe260d2c73f919e62b11439a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Relates to PR #117