Ensure prop-types transform works with object pattern in arg #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| It looks like #115 is trying to fix the same issue. I'm happy to update this if you'd prefer to check |
| Sorry mate. Didn't see this. Already merged a similar fix (PR #127). Going to close this as a dup but I really appreciate the effort! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
prop-typestransform assumes nodes of typeObjectPatternhave a parent node with aninitproperty. This is not the case when anObjectPatternis used in function params or call expression arguments (e.g.function foo({bar}) {}orfoo({bar})).It looks like this is meant to be working with a
VariableDeclaratorparent. I've added a test that demonstrates the existing problem and updated the transform so the test passes.