Skip to content

create-element-to-jsx-children: Convert .map calls into a JSXExpressi… #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2015
Merged

create-element-to-jsx-children: Convert .map calls into a JSXExpressi… #10

merged 1 commit into from
Nov 9, 2015

Conversation

elicwhite
Copy link
Contributor

…onContainer

This didn't properly handle converting:

var React = require('React'); React.createElement( 'div', null, foo.map(function() {}) );

to:

var React = require('React'); <div>{foo.map(function() {})}</div>;

Now it does! :)
@elicwhite elicwhite mentioned this pull request Nov 8, 2015
Merged
@cpojer
Copy link
Member

cpojer commented Nov 9, 2015

nice!
cpojer added a commit that referenced this pull request Nov 9, 2015
@cpojer
Merge pull request #10 from TheSavior/children-expression
e5c5dcc 
create-element-to-jsx-children: Convert .map calls into a JSXExpressi…
@cpojer cpojer merged commit e5c5dcc into reactjs:master Nov 9, 2015
@elicwhite elicwhite deleted the children-expression branch November 9, 2015 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

3 participants

@elicwhite @cpojer @facebook-github-bot