Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Conversation

rmorshea
Copy link
Contributor

Builds on top of #9 with minor improvements

@rmorshea rmorshea force-pushed the remove-reliance-on-CamelCase branch from feefba9 to e816dde Compare August 24, 2022 05:52
@rmorshea rmorshea requested a review from Archmonger August 24, 2022 05:53
@Archmonger
Copy link
Contributor

Archmonger commented Aug 24, 2022

Using regex to get that idom.component.component case seems a bit overkill imo. I'm okay with it though.

You might want to add a test for it if you're complicating things just for that accomodation.

👎 to force pushing a remote branch though 🥺

@rmorshea
Copy link
Contributor Author

did i do that again? this is a new PR

@Archmonger
Copy link
Contributor

Yep
image

@Archmonger
Copy link
Contributor

Archmonger commented Aug 24, 2022

Ohhh I see it is a new PR. Didn't pay close enough attention while reading on mobile.

@rmorshea rmorshea force-pushed the remove-reliance-on-CamelCase branch 4 times, most recently from a964dd2 to 79408d8 Compare September 5, 2022 20:48
@rmorshea rmorshea force-pushed the remove-reliance-on-CamelCase branch from 79408d8 to 64b7b17 Compare September 5, 2022 20:51
@rmorshea rmorshea merged commit fe01dcb into main Sep 15, 2022
@rmorshea rmorshea deleted the remove-reliance-on-CamelCase branch September 15, 2022 05:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants