Skip to content

Improve Caching Schema #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 20, 2022
Merged

Improve Caching Schema #50

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8f57a9c
clean up caching schema
Archmonger Jan 12, 2022
acae088
remove duplicate comment
Archmonger Jan 12, 2022
38f96af
delete stale keys
Archmonger Jan 12, 2022
e3ba4f0
use Django async caching
Archmonger Jan 12, 2022
9b6eaf9
remove Python 3.7 tests
Archmonger Jan 12, 2022
99086b7
need quotes around python-version in matrix
Archmonger Jan 12, 2022
b516bb2
use aiofile
Archmonger Jan 13, 2022
95144e7
Merge remote-tracking branch 'upstream/main' into fix-caching
Archmonger Jan 13, 2022
a2b4947
re-add spacing in pkg-deps
Archmonger Jan 13, 2022
a631c0d
fix docstring
Archmonger Jan 13, 2022
fe2dd92
remove useless delete
Archmonger Jan 13, 2022
194aba4
set IDOM_CACHE to the cache backend object
Archmonger Jan 14, 2022
5e24342
Revert "remove useless delete"
Archmonger Jan 14, 2022
7ee012c
remove unused import
Archmonger Jan 14, 2022
d07c00d
change py and django reqs
Archmonger Jan 16, 2022
fca2201
protect against malicious path attacks
Archmonger Jan 16, 2022
0a340a2
dir agnostic cache key invalidation
Archmonger Jan 16, 2022
1c103dc
clean up comments
Archmonger Jan 16, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Django async caching
  • Loading branch information
@Archmonger
Archmonger committed Jan 12, 2022
commit e3ba4f061fd7d6a0e3c7fa84fd1d1a88d64fa83f
8 changes: 5 additions & 3 deletions src/django_idom/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ async def web_modules_file(request: HttpRequest, file: str) -> HttpResponse:
path = IDOM_WED_MODULES_DIR.current.joinpath(*file.split("/")).absolute()
last_modified_time = os.stat(path).st_mtime
cache_key = f"django_idom:{path}"
response = idom_cache.get(cache_key, version=last_modified_time)
response = await idom_cache.aget(cache_key, version=last_modified_time)
if response is None:
response = HttpResponse(path.read_text(), content_type="text/javascript")
idom_cache.delete(cache_key)
idom_cache.set(cache_key, response, timeout=None, version=last_modified_time)
await idom_cache.adelete(cache_key)
await idom_cache.aset(
cache_key, response, timeout=None, version=last_modified_time
)
return response