Skip to content

Add "name" to WS and Web Module paths #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Add "name" to WS and Web Module paths #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ffd078
Add "name" to WS and Web Module paths
Archmonger Dec 15, 2021
6a35479
fix styling error
Archmonger Dec 15, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/django_idom/paths.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@


IDOM_WEBSOCKET_PATH = path(
IDOM_WEBSOCKET_URL + "<view_id>/", IdomAsyncWebsocketConsumer.as_asgi()
IDOM_WEBSOCKET_URL + "<view_id>/",
IdomAsyncWebsocketConsumer.as_asgi(),
name="idom_websocket",
)
"""A URL resolver for :class:`IdomAsyncWebsocketConsumer`

Expand All @@ -17,7 +19,9 @@


IDOM_WEB_MODULES_PATH = path(
IDOM_WEB_MODULES_URL + "<path:file>", views.web_modules_file
IDOM_WEB_MODULES_URL + "<path:file>",
views.web_modules_file,
name="idom_web_modules",
)
"""A URL resolver for static web modules required by IDOM

Expand Down
1 change: 0 additions & 1 deletion src/django_idom/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ async def web_modules_file(request: HttpRequest, file: str) -> HttpResponse:
file_path = IDOM_WED_MODULES_DIR.current.joinpath(*file.split("/"))
return HttpResponse(file_path.read_text(), content_type="text/javascript")


else:
_web_module_cache = caches[IDOM_WEB_MODULE_CACHE]

Expand Down