Skip to content

Running ReactPy in a backhaul thread #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Aug 4, 2023
Merged

Running ReactPy in a backhaul thread #163

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
1f5ed0d
Running ReactPy in a backhaul thread
Archmonger Jul 11, 2023
026676e
less LOCs for backhaul thread
Archmonger Jul 11, 2023
ecb2a0d
simplier effect
Archmonger Jul 11, 2023
f77c5e8
remove excess div
Archmonger Jul 11, 2023
52be745
move RPS endpoint
Archmonger Jul 13, 2023
8e8cb72
add whitenoise
Archmonger Jul 13, 2023
5c01a84
Allow for testing multiple renderers
Archmonger Jul 13, 2023
712c1ea
set debug
Archmonger Jul 13, 2023
a60bb64
sort
Archmonger Jul 13, 2023
64175c4
add component count
Archmonger Jul 13, 2023
e71b402
Add TTL
Archmonger Jul 13, 2023
f997001
add ttl tests
Archmonger Jul 13, 2023
8c3a354
receive queue does not need to be threaded
Archmonger Jul 13, 2023
868c26e
rename loop function
Archmonger Jul 13, 2023
6ab1742
Revert "receive queue does not need to be threaded"
Archmonger Jul 13, 2023
e65f86a
ensure todo list entries are unique
Archmonger Jul 13, 2023
c54c216
events per second tests
Archmonger Jul 14, 2023
5fd014f
use text input instead
Archmonger Jul 14, 2023
8187df7
rename EPS
Archmonger Jul 14, 2023
f434e4c
net io TTL
Archmonger Jul 14, 2023
d8e3b0b
mixed TTL
Archmonger Jul 14, 2023
8866f3f
Add config setting for backhaul thread
Archmonger Jul 14, 2023
12e7ea0
fix formatting
Archmonger Jul 14, 2023
ac03724
add changelog
Archmonger Jul 14, 2023
517caf9
add backhaul to dictionary
Archmonger Jul 14, 2023
ddd718f
Remove excess exceptions, potential attack vector
Archmonger Jul 14, 2023
11b93b4
add logging for daphne issues
Archmonger Jul 14, 2023
690fbda
eps -> erps
Archmonger Jul 15, 2023
bdbe9f0
event timing
Archmonger Jul 15, 2023
b6cb92f
better daphne check
Archmonger Jul 15, 2023
91f90d4
I really hate Ruff
Archmonger Jul 15, 2023
b8c1a9a
change comment
Archmonger Jul 16, 2023
993fe45
better debug check
Archmonger Jul 16, 2023
7b928b4
make run dispatcher public
Archmonger Jul 19, 2023
143c2cd
cleanup
Archmonger Jul 20, 2023
92e9eed
threading for all logging
Archmonger Jul 22, 2023
2f2135f
switch to ruff
Archmonger Jul 22, 2023
6b77479
change line length
Archmonger Jul 22, 2023
8d19322
bump minimum python version
Archmonger Jul 22, 2023
356ed88
use ruff for docs
Archmonger Jul 22, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Running ReactPy in a backhaul thread
  • Loading branch information
@Archmonger
Archmonger committed Jul 11, 2023
commit 1f5ed0d88fbd4d9b56bef28630060f066e905ea3
26 changes: 19 additions & 7 deletions src/reactpy_django/websocket/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import asyncio
import logging
from datetime import timedelta
from threading import Thread
from typing import Any, MutableMapping, Sequence

import dill as pickle
Expand All @@ -23,6 +24,18 @@
_logger = logging.getLogger(__name__)


def start_background_loop(loop: asyncio.AbstractEventLoop) -> None:
asyncio.set_event_loop(loop)
loop.run_forever()


backhaul_loop = asyncio.new_event_loop()
backhaul_thread = Thread(
target=start_background_loop, args=[backhaul_loop], daemon=True
)
backhaul_thread.start()


class ReactpyAsyncWebsocketConsumer(AsyncJsonWebsocketConsumer):
"""Communicates with the browser to perform actions on-demand."""

Expand Down Expand Up @@ -58,21 +71,20 @@ async def connect(self) -> None:
)

# Start allowing component renders
self._reactpy_dispatcher_future = asyncio.ensure_future(
self._run_dispatch_loop()
self._reactpy_dispatcher_future = asyncio.run_coroutine_threadsafe(
self._run_dispatch_loop(), loop=backhaul_loop
)

async def disconnect(self, code: int) -> None:
"""The browser has disconnected."""
if self._reactpy_dispatcher_future.done():
await self._reactpy_dispatcher_future
else:
self._reactpy_dispatcher_future.cancel()
self._reactpy_dispatcher_future.cancel()
await super().disconnect(code)

async def receive_json(self, content: Any, **_) -> None:
"""Receive a message from the browser. Typically messages are event signals."""
await self._reactpy_recv_queue.put(content)
asyncio.run_coroutine_threadsafe(
self._reactpy_recv_queue.put(content), loop=backhaul_loop
)

async def _run_dispatch_loop(self):
"""Runs the main loop that performs component rendering tasks."""
Expand Down
20 changes: 20 additions & 0 deletions tests/test_app/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import asyncio
import inspect
from datetime import datetime, timedelta
from pathlib import Path

from channels.db import database_sync_to_async
Expand All @@ -24,6 +25,25 @@
from .types import TestObject


@component
def test_runner():
start_time, _set_start_time = hooks.use_state(datetime.now())
count, set_count = hooks.use_state(0)
running = datetime.now() - start_time < timedelta(seconds=60)
seconds_elapsed = (datetime.now() - start_time).total_seconds()

@hooks.use_effect
def run_tests():
if running:
set_count(count + 1)

return html.div(
{"id": "test-runner"},
html.div(f"Total renders: {count}"),
html.div(f"Renders Per Second: {count / (seconds_elapsed or 0.01)}"),
)


@component
def hello_world():
return html._(html.div({"id": "hello-world"}, "Hello World!"))
Expand Down
2 changes: 1 addition & 1 deletion tests/test_app/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
SECRET_KEY = "django-insecure-n!bd1#+7ufw5#9ipayu9k(lyu@za$c2ajbro7es(v8_7w1$=&c"

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = "test" not in sys.argv
DEBUG = False
ALLOWED_HOSTS = ["*"]

# Application definition
Expand Down
71 changes: 1 addition & 70 deletions tests/test_app/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,76 +19,7 @@
<body>
<h1>ReactPy Test Page</h1>
<hr>
{% component "test_app.components.hello_world" class="hello-world" %}
<hr>
{% component "test_app.components.button" class="button" %}
<hr>
{% component "test_app.components.parameterized_component" class="parametarized-component" x=123 y=456 %}
<hr>
{% component "test_app.components.object_in_templatetag" my_object %}
<hr>
{% component "test_app.components.simple_button" %}
<hr>
{% component "test_app.components.use_connection" %}
<hr>
{% component "test_app.components.use_scope" %}
<hr>
{% component "test_app.components.use_location" %}
<hr>
{% component "test_app.components.use_origin" %}
<hr>
{% component "test_app.components.django_css" %}
<hr>
{% component "test_app.components.django_js" %}
<hr>
{% component "test_app.components.unauthorized_user" %}
<hr>
{% component "test_app.components.authorized_user" %}
<hr>
{% component "test_app.components.relational_query" %}
<hr>
{% component "test_app.components.async_relational_query" %}
<hr>
{% component "test_app.components.todo_list" %}
<hr>
{% component "test_app.components.async_todo_list" %}
<hr>
{% component "test_app.components.view_to_component_sync_func" %}
<hr>
{% component "test_app.components.view_to_component_async_func" %}
<hr>
{% component "test_app.components.view_to_component_sync_class" %}
<hr>
{% component "test_app.components.view_to_component_async_class" %}
<hr>
{% component "test_app.components.view_to_component_template_view_class" %}
<hr>
{% component "test_app.components.view_to_component_script" %}
<hr>
{% component "test_app.components.view_to_component_request" %}
<hr>
{% component "test_app.components.view_to_component_args" %}
<hr>
{% component "test_app.components.view_to_component_kwargs" %}
<hr>
{% component "test_app.components.view_to_component_sync_func_compatibility" %}
<hr>
{% component "test_app.components.view_to_component_async_func_compatibility" %}
<hr>
{% component "test_app.components.view_to_component_sync_class_compatibility" %}
<hr>
{% component "test_app.components.view_to_component_async_class_compatibility" %}
<hr>
{% component "test_app.components.view_to_component_template_view_class_compatibility" %}
<hr>
{% component "test_app.components.view_to_component_decorator" %}
<hr>
{% component "test_app.components.view_to_component_decorator_args" %}
<hr>
<div id="component_does_not_exist_error">{% component "test_app.components.does_not_exist" %}</div>
<hr>
<div id="component_param_error">{% component "test_app.components.hello_world" invalid_param="random_value" %}</div>
<hr>
<div>{% component "test_app.components.test_runner" %}</div>
</body>

</html>