fix(types): utility type removed from RN 0.71

[alpha0010]

Overview

Updating to react native 0.71, TypeScript errors on this library. The utility type Constructor is private in latest typings. Using this export degrades to any type.

JSX element class does not support attributes because it does not have a 'props' property.

Test Plan

npx tsc runs clean after making this change on a RN 0.71 app.

[go-sean-go]

Just to point out, RN 0.71 is now TypeScript-by-default, so this library will fail for all new projects without this or some other fix.

(btw, I am using @alpha0010's fix and it works for me!)

[JoniVR]

Aww shit, here I go patching again, a day in the life of a RN developer...
God bless patch-package

Anyone wanting the .patch file (or just append .diff/.patch behind the url of this PR):

diff --git a/node_modules/@react-native-segmented-control/segmented-control/index.d.ts b/node_modules/@react-native-segmented-control/segmented-control/index.d.ts index b914477..040f29c 100644 --- a/node_modules/@react-native-segmented-control/segmented-control/index.d.ts +++ b/node_modules/@react-native-segmented-control/segmented-control/index.d.ts @@ -6,11 +6,12 @@ import { ViewProps, NativeSyntheticEvent, NativeMethods, - Constructor, TargetedEvent, ViewStyle, } from 'react-native'; +type Constructor<T> = new (...args: any[]) => T; + export interface NativeSegmentedControlIOSChangeEvent extends TargetedEvent { value: string; selectedSegmentIndex: number;

Can a maintainer please merge this?

[narliecholler]

any timeframe on merging this?

@Naturalclar :D

[Naturalclar]

LGTM!

[Naturalclar]

@narliecholler thanks for the ping! just released new version with the fix as 2.4.1

[narliecholler]

⭐