Skip to content

Fix Animation Active segmant width in RTL #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2020
Merged

Fix Animation Active segmant width in RTL #121

merged 2 commits into from
Sep 16, 2020

Conversation

anastely
Copy link
Contributor

@anastely anastely commented Sep 2, 2020

Overview

I have a Fully RTL App when I press to next segment the Animation It goes the other way around

Test Plan

I import I18nManager then defined a variable to check if the app RTL or not and based on it, I change segmentWidth to negative if true, else i return segmentWidth

Before
Screen-Recording-2020-09-02-at-5

After

Screen-Recording-2020-09-02-at-6
Naturalclar
Naturalclar approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastely thank you!
@Naturalclar Naturalclar merged commit 68652d8 into react-native-segmented-control:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@anastely @Naturalclar