feat: Add support for images #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sahith02 approved these changes Jun 22, 2020
Naturalclar approved these changes Jul 4, 2020
| Any plans to add Expo support for images? @andresain123 @Naturalclar |
| I need @expo/vector-icons support too! @andresain123 @Naturalclar |
| @sergey-king to be honest I don't know how Expo handles the native libraries, but I think they have to update their internal version of the segmented control to 2.1.0+ in order for you to have support on the new features. @yingtao-futurewonder I'll see what I can do to support individual react components on the segmented control values. |
| Hey, thanks for this feature! @andresain123 Looks like it must be problematic with modern version of iOS?  |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request adds support for images inside segmented controls.
An example of how it works:
<SegmentedControl values={['One', 'Two', require('../assets/images/user.png')]} />Fixes: #71
Test Plan
The example app is updated with this new functionality
Some previews:
