Update component prop to Component #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Example app for the last commit (df46c67): |
Codecov Report
@@ Coverage Diff @@ ## next #1479 +/- ## ======================================== - Coverage 74.79% 74.5% -0.3% ======================================== Files 33 33 Lines 615 608 -7 Branches 88 85 -3 ======================================== - Hits 460 453 -7 Misses 132 132 Partials 23 23
Continue to review full report at Codecov.
|
iRoachie added a commit that referenced this pull request Oct 28, 2018
* refactor(Avatar): Change component prop to Component * refactor(Badge): Change component prop to Component * refactor(ButtonGroup): Change component prop to Component * refactor(CheckBox): Change component prop to Component * refactor(Icon): Change component prop to Component * refactor(ListItem): Change component prop to Component * refactor(SocialIcon): Change component prop to Component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change all components that have the
componentprop toComponentas per convention