Add minute interval on Android #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
luancurti force-pushed the feat/minute-interval branch from 58617ec to 7dd3446 Compare luancurti force-pushed the feat/minute-interval branch 7 times, most recently from e54fa0c to 087813c Compare 
vonovak requested changes May 23, 2020
Member
vonovak left a comment
vonovak left a comment There was a problem hiding this comment.
thanks so much for taking the initiative here! I left some comments that would be nice to clarify. Thanks!
android/src/main/java/com/reactcommunity/rndatetimepicker/CustomTimePickerDialog.java Outdated Show resolved Hide resolved
android/src/main/java/com/reactcommunity/rndatetimepicker/CustomTimePickerDialog.java Outdated Show resolved Hide resolved
android/src/main/java/com/reactcommunity/rndatetimepicker/CustomTimePickerDialog.java Outdated Show resolved Hide resolved
android/src/main/java/com/reactcommunity/rndatetimepicker/CustomTimePickerDialog.java Outdated Show resolved Hide resolved
android/src/main/java/com/reactcommunity/rndatetimepicker/CustomTimePickerDialog.java Outdated Show resolved Hide resolved
luancurti force-pushed the feat/minute-interval branch 2 times, most recently from b897f7d to cd79ddc Compare luancurti force-pushed the feat/minute-interval branch 8 times, most recently from 486b23c to cd4e24c Compare vonovak reviewed Jun 10, 2020
android/src/main/java/com/reactcommunity/rndatetimepicker/RNConstants.java Outdated Show resolved Hide resolved
luancurti force-pushed the feat/minute-interval branch from cd4e24c to b11edd9 Compare 
| Thanks for picking it up! |
vonovak force-pushed the feat/minute-interval branch from b11edd9 to 23708f4 Compare 
Member
| @luancurti this was a little harder than I anticipated but I did some refactors and it should be running smooth now; can you please take a look at this and test it out? Thanks! |
Member Author
@vonovak sounds good to me, thanks for help! |
Member Author
| @vonovak tested in iOS and Android and everything is working ok! I re-request your review and I think you can approve this PR. |
vonovak approved these changes Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Add minute interval on Android, thanks to @BenderBRodrigez and @e1ferapontov to contribute with this feature
Closes #99
Test Plan
Run example App on Android and test if minute interval works on time picker with mode default and spinner
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)