Cancel InteractionManager's task on unmount #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix for this warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function
LinusU reviewed May 23, 2023
Comment on lines +8 to +13
| const {cancel} = InteractionManager.runAfterInteractions(() => { | ||
| updateInteractionStatus(true) | ||
| }) | ||
| | ||
| return () => { | ||
| cancel?.() |
There was a problem hiding this comment.
runAfterInteractions returns a promise and I'm not sure if they are required to have their methods bound so that they work without this being set 🤔
Also, I think that cancel will always be set, right? It's documented as returning a cancelable promise 🤔
What do you think about this instead:
Suggested change
| const {cancel} = InteractionManager.runAfterInteractions(() => { | |
| updateInteractionStatus(true) | |
| }) | |
| return () => { | |
| cancel?.() | |
| const promise = InteractionManager.runAfterInteractions(() => { | |
| updateInteractionStatus(true) | |
| }) | |
| return () => { | |
| promise.cancel() |
| already fixed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are some cases when interaction manager's task executing when component have already unmounted and React return a warning when setState happed on unmounted component. The whole warning you can see below:
Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup functionSo this tiny fix will cancel task on component unmount.