hydration and cleanup changes #414
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-figma/react-figma/97zBUod83guW1rdt4o1yJXFGrhFL |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These changes were made through a process of trial and error, and possibly there is a reason why you have opted not to implement these methods.
They seemed to enable rehydration to work nicely with my usage though, I've marked it as draft, because I'm not familiar with the react-reconcilier, and did not find much documentation (and implemented these methods based on another reconciler I found https://github.com/zongzi531/zzeact/blob/4f80fed8f98a15e2769badf5f5d96fc05d67f02d/packages/zzeact-dom/src/client/ZzeactDOMHostConfig.ts)