feat: add previewValue option #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meet-student changed the title 
Walkthrough为 Picker/RangePicker 新增可选属性 previewValue（'hover' 或 false，默认 'hover'），用以控制悬浮时是否预览输入值。更新了类型与默认填充逻辑、组件悬浮处理分支、文档与示例，并添加对应测试用例。 Changes
Sequence Diagram(s)sequenceDiagram participant U as 用户 participant P as Picker/RangePicker participant S as 内部状态 U->>P: 悬浮单元格或预设 P->>P: 检查 previewValue alt previewValue == 'hover' P->>S: 更新 internal hover value S-->>P: 返回预览值 P-->>U: 输入框显示预览 else previewValue == false P-->>U: 忽略悬浮（不预览） end Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File ( |
meet-student changed the title 
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #934 +/- ## ======================================= Coverage 98.80% 98.80% ======================================= Files 65 65 Lines 2669 2676 +7 Branches 742 745 +3 ======================================= + Hits 2637 2644 +7 Misses 29 29 Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
afc163 reviewed Jul 24, 2025
src/PickerInput/SinglePicker.tsx Outdated
| // ======================== Panel ========================= | ||
| const onPanelHover = (date: DateType | null) => { | ||
| setInternalHoverValue(date); | ||
| if (showPreviewValue) { |
There was a problem hiding this comment.
showHoverValue 如何？
类 Select 组件之后也可以支持一下这个功能
meet-student changed the title 
| 突然想到，是否可以 previewValue={(info: { date }) => xxxx} |
meet-student changed the title afc163 reviewed Aug 12, 2025
afc163 reviewed Aug 12, 2025
afc163 reviewed Aug 12, 2025
afc163 reviewed Aug 12, 2025
meet-student force-pushed the feat-showPreviewValue branch from 8dfd0b3 to 515b51c Compare 
| @afc163 都已修改 |
zombieJ approved these changes Sep 9, 2025
| 优雅👍🏻 |
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
Summary by CodeRabbit