feat: support aria-labelledby and aria-describedby for dialog in Panel #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The DrawerPanel has a dialog role which should support aria-labelledby and aria-describedby attributes.
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor Author
| @zombieJ if you can take a look when you get the chance :) |
Member
| Conflicting |
Contributor Author
| @afc163, all resolved. |
yoyo837 reviewed Feb 5, 2024
Member
| We should change this line. - {...pickAttrs(props, { data: true })} + {...pickAttrs(props, { data: true, aria: true })} |
Contributor Author
| @afc163, won't that apply it to the container div instead of the Panel having the div with the role=dialog? The goal was to make the the dialog queryable via the attributes. But I could definitely leverage that instead of my custom function. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #425 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 148 148 Branches 53 53 ========================================= Hits 148 148 ☔ View full report in Codecov by Sentry. |
Member
| @kapiljaveri You are right. |
Contributor Author
| Awesome, thanks for the review! |
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The DrawerPanel has a dialog role which should support aria-labelledby and aria-describedby attributes.