Update README, overlayFactory example #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
workgena changed the title workgena changed the title 
| @workgena thanks for your contribution, would you please fix the check fails? it's seems like fail due to unit test. |
workgena changed the title 
Update example of usage `overlayFactory` according to "react-loading-overlay" documentation.
workgena changed the title 
| The problem was with linter code-style. Fixed. |
| @workgena thanks, I will release in next version. 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why?
Current example
overlayFactory(spinner: true, background: 'red')does not work.Solution:
Update example of usage
overlayFactoryaccording to "react-loading-overlay" documentation Custom overlay background (extending base styles).The correct format if: