Skip to content

Conversation

AllenFang
Copy link
Member

#63

  • Support Cell Editing with Promise
  • Support Cell Editing with Redux way(A little complicated, I'll keep to figure if we can simply it)

Some things need to change after merging this PR:

  1. Refine stateful-layer.js
  2. Implement a wrapper for sorting
  3. Fix promise hard to test problem
@AllenFang AllenFang added this to the 0.1.0 milestone Oct 10, 2017
@AllenFang AllenFang requested a review from chunming-c October 10, 2017 16:05
@AllenFang AllenFang force-pushed the feat/cell-editing-async branch from 28ee868 to f7b0745 Compare October 10, 2017 16:47
@AllenFang AllenFang changed the title [WIP] Implement async cell edit Implement async cell edit Oct 11, 2017
@AllenFang AllenFang force-pushed the feat/cell-editing-async branch from f7b0745 to e587d53 Compare October 17, 2017 07:19
@AllenFang AllenFang merged commit 7a5b88b into develop Oct 17, 2017
@AllenFang
Copy link
Member Author

@Chun-MingChen

I wanna merge this PR ASAP and also I did some changes about design, I'll create another PR to keep to refactor other parts, thanks

  1. I create HOC that was charge for cell editing operation so that in this PR bootstrap-table.js will be more clean
    https://github.com/react-bootstrap-table/react-bootstrap-table2/blob/develop/packages/react-bootstrap-table2/src/cell-edit-wrapper.js

  2. cell-edit-wrapper.js will be used in stateful-layer, also I will redefine the role of stateful-layer

  3. bootstrap-table will be more stateless after this PR and I already decide not to export bootstrap-table in the index.js and we only export the BootstraTable which always wrapper by stateful-layer

I can explain more details on Line if you have any concern and let me know your idea. thanks.

@AllenFang AllenFang deleted the feat/cell-editing-async branch October 17, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant