Feat/cell editor valiation #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chunming-c reviewed Sep 24, 2017
| ridx: editingRowIdx, | ||
| cidx: editingColIdx, | ||
| ...rest | ||
| } = cellEdit; |
There was a problem hiding this comment.
Hi @AllenFang,
Sorry for comment late. I saw cellEdit was passed as prop but neither marked as required nor with defaultProps. Therefore, I have one suggestion to set defaultProp of cellEdit to empty object or anthing else to prevent missing prop issue :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A part of #63, I'll open another PR for handling the async cell editing.