fix #641 typo #649
Merged
fix #641 typo #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @AllenFang Tagging you as requested. Thanks for getting the updates into a new release so quickly :D. |
| ok, I will handle this, thanks |
| https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/11/10/version-bump.html Please upgrade to newest version, thanks. |
YassienW pushed a commit to YassienW/react-bootstrap-table2 that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You swapped
valueandlabelin the fix for #641.This corrects that swap.
You will also want to update your docs as it currently uses a swapped example: