Skip to content

Development/redefine cell callback (#56) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 16, 2017
Merged

Development/redefine cell callback (#56) #58

merged 6 commits into from
Sep 16, 2017

Conversation

@chunming-c
Copy link
Member

#56

Description

  1. re-define cell callback to allow user to pass 4 arguments cell, row, rowIndex, colIndex.
  2. re-structure document and write in more detail
@chunming-c
redefine cell callback function
54fd58f 
* it takes 4 argus `content`, `row`, `rowIndex` and `columnIndex` in * sequence.
@chunming-c
[test] fix unit test for new callback
87e6cc9
@chunming-c
correct the version of story for new cell callback
e031918
@chunming-c
[DOC] re-define structure of Contents of Table
3b722fc
@chunming-c
[DOC] update document for attrs
bfa4ab8 
* re-write description for each column props
@chunming-c
[DOC] update document for headerCell
ea6efa4 
* re-write and add extra description for each header column props
@chunming-c chunming-c added this to the 0.1.0 milestone Sep 12, 2017
AllenFang
AllenFang approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your hard work 🇹🇼
@AllenFang AllenFang merged commit ec1a927 into react-bootstrap-table:develop Sep 16, 2017
@chunming-c chunming-c deleted the development/redefine-cell-callback branch October 8, 2017 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development

2 participants

@chunming-c @AllenFang