Resolved issues with Date Filter to make its behavior the same as Number Filter #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
table when the date or date comparator were cleared Modified applyFilter in date.js so that it doesn't try to parse an Invalid Date. It was parsing an empty string, which caused it to pass through an invalid date to onFilter, and this wasn't being checked for properly by the onFilter function. It now checks for the empty string and passes in null, which is what the onFilter function was actually checking for
AllenFang approved these changes Jul 25, 2018
| @BennyAJ thanks your contribution, I will release in this weekend :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix for my issue #423
Commented out a check which caused the date filter to not update the table when the date or date comparator were cleared
Modified applyFilter in date.js so that it doesn't try to parse an
Invalid Date. It was parsing an empty string, which caused it to pass
through an invalid date to onFilter, and this wasn't being checked for
properly by the onFilter function. It now checks for the empty string
and passes in null, which is what the onFilter function was actually
checking for